Fix bizard-skill.zip download link resolving to wrong path on sub-pages#277
Merged
ShixiangWang merged 2 commits intomainfrom Apr 16, 2026
Merged
Fix bizard-skill.zip download link resolving to wrong path on sub-pages#277ShixiangWang merged 2 commits intomainfrom
ShixiangWang merged 2 commits intomainfrom
Conversation
The segmentsAfterRoot calculation used parts.length - 2 (subtracting only the empty string and site root), but forgot to subtract the filename itself. Pages like /Bizard/Distribution/Density.html ended up with ../../bizard-skill.zip resolving to /bizard-skill.zip instead of /Bizard/bizard-skill.zip. Fix: use Math.max(0, parts.length - 3) in skill-button.lua, Skills.qmd, and Skills.zh.qmd. Agent-Logs-Url: https://github.com/openbiox/Bizard/sessions/e8c5f250-0592-47e3-8660-74694f4374fd Co-authored-by: ShixiangWang <25057508+ShixiangWang@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix Bizard skill zip path inconsistencies on website
Fix bizard-skill.zip download link resolving to wrong path on sub-pages
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
bizard-skill.zipdownload link was broken on any page below the site root (e.g.Distribution/Density.html), resolving to/bizard-skill.zipinstead of/Bizard/bizard-skill.zip.Root Cause
The JS path calculation subtracted only 2 from
parts.length— accounting for the leading''and the site root segment — but forgot to subtract the filename itself:For
/Bizard/Distribution/Density.html(parts.length = 4):4 - 2 = 2→../../bizard-skill.zip→/bizard-skill.zip❌max(0, 4 - 3) = 1→../bizard-skill.zip→/Bizard/bizard-skill.zip✅Changes
skill-button.lua— fixes the button injected into every tutorial pageSkills.qmd/Skills.zh.qmd— fixes the same logic on the Skills landing pages